Fix incorrect suggestion for enum variant #146672
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
This comment was marked as outdated.
This comment was marked as outdated.
|
Actually you don't need fn_traits, |
This comment has been minimized.
This comment has been minimized.
|
Does this also fix #146706? |
Not automatically fixed. But this bug also seems to be related with garbled suggestions generating overlapping spans. |
|
will conflict with #146731 |
|
I think these commits deserve some squashing (though I realize now that this is a draft, feedback may be premature) |
…eneric on variant of type-aliased enum
NKID00
force-pushed
the
fix-issue-146586
branch
from
cf2fc3d to
c1ed215
Compare
fmease
reviewed
Sep 20, 2025
Comment on lines
+3
to
+4
| //@ only-linux | ||
| //@ compile-flags: --error-format=human --color=always |
There was a problem hiding this comment.
Suggested change
| //@ only-linux | |
| //@ compile-flags: --error-format=human --color=always |
I know this is a WIP PR but please don't keep this test Linux exclusive (that's just worse DX for Windows rustc devs) and don't keep it as an SVG test, there's no reason to add a 1100 line SVG for this diagnostic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #130395, fixes #146261, fixes #146586 and fixes #146706.